Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client and stream processing updates #506

Merged
merged 68 commits into from
Sep 13, 2023
Merged

Client and stream processing updates #506

merged 68 commits into from
Sep 13, 2023

Conversation

MoojMidge
Copy link
Collaborator

Also includes:

  • updates to enable HLS live streams using ISA
  • updates to quality and stream feature selection
  • improved handling of connection failures
  • improved stream and language labelling
  • option to separately enable/disable local and remote history tracking
  • other stuff I have forgotten

MoojMidge added 30 commits May 25, 2023 21:46
@MoojMidge
Enable HLS and adaptive HLS live streams
6264b40
@MoojMidge
Update server request log messages
63999db
@MoojMidge
Add default IP param to IP address setting getter
db2cf73
@MoojMidge
Add some basic error handling for https session
d9585ce
@MoojMidge
Merge branch 'requests'
8a68806
@MoojMidge
Merge branch 'captions'
e7a32ce
@MoojMidge
Merge branch 'live_streams'
878a98d
@MoojMidge
Implement original single stream live HLS playback
bb2e46e
@MoojMidge
Merge branch 'live_streams'
96cdb0c
@MoojMidge
Fix live stream settings options when MPD disabled
3367f25
@MoojMidge
Merge branch 'live_streams'
19a09cc
@MoojMidge
Remove Authorisation header from HLS request
6ca3762 
- Header is not needed as url has already been retrieved using API
@MoojMidge
Merge branches 'captions' and 'live_streams'
8fbebef
@MoojMidge
Merge branch 'captions'
db7f8d0
@MoojMidge
Merge branch 'stream_selection'
a3212f2
@MoojMidge
Merge branch 'stream_selection'
8304be5
@MoojMidge
Merge branch 'stream_selection'
e983ce8
@MoojMidge
Merge branch 'stream_selection'
2201d8c
@MoojMidge
Merge branch 'stream_selection'
4346fcf
@MoojMidge
Standardise/change "dash" in names to "mpd"
2ba69cc
@MoojMidge
Fix evaluation of single ISA capability
5bbca4b
@MoojMidge
Improve stream quality and features selection
7fd9fab
@MoojMidge
Standardise setting attribute order
3f7cada
@MoojMidge
Improve MPD manifest language sorting
3834a94 
- ISA will still override this and sort by bandwidth
@MoojMidge
Fix incorrect return on create directory failure
e96c59c
@MoojMidge
Fix sorting of stream chooser
a17d442 
Sorts based on:
- quality
- preferred language
- original language
- language name (in English...)
@MoojMidge
Move get_language_name to kodion context class
83275ed
@MoojMidge
Fix sorting of ISA audio chooser
762d2f2 
- Also improve visibility of stream details
- Details in square brackets are max quality level of an adaptive stream
- Streams without square brackets have a single fixed quality level
- Duplication of language in name is unavoidable
@MoojMidge
Fix filtering streams when auto selection disabled
53fdcdd
@MoojMidge
Code tidy up
df9aae4
@MoojMidge
Copy link
Collaborator Author

That's good, but what 403 issue?

If it was when you were trying to play a video it is probably fixed by this

If it was when you were searching or opening a channel or playlist then I'm not sure which specific change fixed that as it was somewhat intermittent and I was never sure if it just went away because of some YouTube change.

@prometheanfire
Copy link

ya, that seems to be it

@jaylinski
Copy link
Contributor

jaylinski commented Aug 11, 2023 •
edited
Loading

not sure what the fix was (haven't bisected) but this fixed my current 403 issue

Can confirm, this fixes my 403 errors too (which resulted in a buzzing sound after about 12 seconds into the video and a frozen video). Did not happen on every video and sometimes a restart of Kodi helped, but the issue got worse in the last few weeks.

Thanks @MoojMidge !

@MoojMidge MoojMidge force-pushed the master branch 7 times, most recently from cf7f645 to 5ae94d3 Compare September 13, 2023 00:18
@MoojMidge MoojMidge marked this pull request as ready for review September 13, 2023 00:23
@MoojMidge MoojMidge merged commit 2501832 into anxdpanic:master Sep 13, 2023
2 checks passed
This was referenced Sep 13, 2023
Closed
Closed
Closed
@MoojMidge MoojMidge linked an issue Sep 14, 2023 that may be closed by this pull request
Increasingly common 403 errors when casting videos #501
Closed
JimmyS83 pushed a commit to JimmyS83/plugin.video.youtube that referenced this pull request Oct 11, 2023
@MoojMidge @JimmyS83
Merge pull request anxdpanic#506 from MoojMidge/master
64901c9 
Client and stream processing updates
This was referenced Dec 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increasingly common 403 errors when casting videos
3 participants
@MoojMidge @prometheanfire @jaylinski